Eliminate the constant location used for literals in the AST....

Eliminate the constant location used for literals in the AST.
Literals now have a location of temporary by default and are
responsible for moving themselves into their location like all other
expressions.

The constant location turned out not to allow us to avoid checking
subexpressions in AST interior nodes, and it turned out to require
checking after some normal calls to Visit (like for the arguments to a
call).  With this change do not have to check after a call to Visit
that we got our result in the expected location.


Committed: http://code.google.com/p/v8/source/detail?r=3137

[fschneider, 2009-10-26 17:57:19]

LGTM.

Small comments about inserting ASSERTs to be more consistent in our code.

http://codereview.chromium.org/339004/diff/1/7
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/339004/diff/1/7#newcode480
Line 480: }
Add an assert here to be consistent with the rest of the code:

else { ASSERT(destination.is_nowhere()); }

http://codereview.chromium.org/339004/diff/1/7#newcode574
Line 574: if (destination.is_temporary()) __ push(r0);
May want to add an assert here to be consistent with the rest of the code:

else ASSERT(destination.is_nowhere());

http://codereview.chromium.org/339004/diff/1/7#newcode581
Line 581: }
Add an assert:

else {
  ASSERT(destination.is_nowhere());
}

http://codereview.chromium.org/339004/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/339004/diff/1/2#newcode475
Line 475: __ push(eax);
Add an assert here to be consistent with the rest of the code:

else { ASSERT(destination.is_nowhere()); }

http://codereview.chromium.org/339004/diff/1/2#newcode571
Line 571: if (destination.is_temporary()) __ push(eax);
May want to add an assert here to be consistent with the rest of the code:

else ASSERT(destination.is_nowhere());

http://codereview.chromium.org/339004/diff/1/2#newcode582
Line 582: __ pop(eax);
Adding an assert to be consistent on all platforms:

ASSERT(destination.is_nowhere());

http://codereview.chromium.org/339004/diff/1/4
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/339004/diff/1/4#newcode487
Line 487: }
Add an assert here to be consistent with the rest of the code:

else { ASSERT(destination.is_nowhere()); }

http://codereview.chromium.org/339004/diff/1/4#newcode582
Line 582: if (destination.is_temporary()) __ push(rax);
May want to add an assert here to be consistent with the rest of the code:

else ASSERT(destination.is_nowhere());

http://codereview.chromium.org/339004/diff/1/4#newcode593
Line 593: __ pop(rax);
Adding an assert to be consistent on all platforms:

ASSERT(destination.is_nowhere());