Remove our local modifications to sqlite's os_unix.c now that

Remove our local modifications to sqlite's os_unix.c now that
http://trac.webkit.org/changeset/68310 has landed.

They are no longer necessary, and are not used.

This brings our sqlite copy a little closer to the upstream version
and is a part of an effort to allow compiling with the system-provided sqlite.

BUG=50769, 22208
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60761

[Scott Hess - ex-Googler, 2010-09-27 21:33:17]

Say ... have you been keeping the patch files and instructions up-to-date with
these changes?  I was going to suggest that you also needed to make changes
there, but AFAICT your changes don't correspond to much of anything in those
files.  Please double-check to make sure that they are updated appropriately.

[It's possible someone else was at fault for not keeping things up-to-date. 
You're just the lucky bloke doing the CL where I noticed it.  If you can find
someone else to deflect blame to, loop them in on the review, here.]

[dumi, 2010-09-28 01:22:29]

On 2010/09/27 21:33:17, shess wrote:
> Say ... have you been keeping the patch files and instructions up-to-date with
> these changes?  I was going to suggest that you also needed to make changes
> there, but AFAICT your changes don't correspond to much of anything in those
> files.  Please double-check to make sure that they are updated appropriately.
> 
> [It's possible someone else was at fault for not keeping things up-to-date. 
> You're just the lucky bloke doing the CL where I noticed it.  If you can find
> someone else to deflect blame to, loop them in on the review, here.]

that's my fault. when i changed os_unix.c, i should've added a os_unix.patch
file and added it to the list of patches we need to apply. as far as i know, the
instructions should be up to date for all other patches.

this change LGTM.

[Scott Hess - ex-Googler, 2010-09-29 20:38:41]

One of you should run through the instructions and verify that none of
your activities has resulted in a future problem for someone.  The
intent of the instructions was that anyone could take the SQLite
tarball for the version checked in, apply the patches, and get exactly
what's checked in.  If that no longer holds, it's possible/likely that
the next person to pull SQLite will have to spend a few days tracking
down people's changes and possibly having things be broken, instead of
doing something more useful like running SQLite's test suite.  I'd
prefer the person making the changes to keep things updated, because
they're best placed to respond to problems.

-scott


On Mon, Sep 27, 2010 at 6:22 PM,  <dumi@chromium.org> wrote:
> On 2010/09/27 21:33:17, shess wrote:
>>
>> Say ... have you been keeping the patch files and instructions up-to-date
>> with
>> these changes?  I was going to suggest that you also needed to make
>> changes
>> there, but AFAICT your changes don't correspond to much of anything in
>> those
>> files.  Please double-check to make sure that they are updated
>> appropriately.
>
>> [It's possible someone else was at fault for not keeping things
>> up-to-date.
>> You're just the lucky bloke doing the CL where I noticed it.  If you can
>> find
>> someone else to deflect blame to, loop them in on the review, here.]
>
> that's my fault. when i changed os_unix.c, i should've added a os_unix.patch
> file and added it to the list of patches we need to apply. as far as i know,
> the
> instructions should be up to date for all other patches.
>
> this change LGTM.
>
> http://codereview.chromium.org/3390032/show
>