net: Append base:: in the StringPrintf calls.

net: Append base:: in the StringPrintf calls.

(Note: This is a TODO in string_util.h)

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60555

[eroman, 2010-09-24 21:31:25]

LGTM

Thanks for converting all of those!

http://codereview.chromium.org/3390026/diff/5001/6003
File net/base/cookie_monster_unittest.cc (right):

http://codereview.chromium.org/3390026/diff/5001/6003#newcode13
net/base/cookie_monster_unittest.cc:13: #include "base/stringprintf.h"
nit: I would sort "stringprintf.h" below "string_util.h", since that is what the
"sort" command does.

(Usually what I do to sort headers in vim is to do a visual selection of the
lines (V), and then type ":!sort")

Comment applies throughout.

[tfarina, 2010-09-24 22:26:20]

On 2010/09/24 21:31:25, eroman wrote:
> LGTM
> 
> Thanks for converting all of those!
> 
> http://codereview.chromium.org/3390026/diff/5001/6003
> File net/base/cookie_monster_unittest.cc (right):
> 
> http://codereview.chromium.org/3390026/diff/5001/6003#newcode13
> net/base/cookie_monster_unittest.cc:13: #include "base/stringprintf.h"
> nit: I would sort "stringprintf.h" below "string_util.h", since that is what
the
> "sort" command does.
> 
Yup!

> (Usually what I do to sort headers in vim is to do a visual selection of the
> lines (V), and then type ":!sort")
>
I tried that, but for some reason that didn't work here :(

Anyway, what I did was:
git diff --name-only "$@" | while read filename; do ./tools/sort-headers.py
"$filename"; done;

After commenting out the line 83 of the sort-headers.py to stop it asking every
time.

[eroman, 2010-09-24 22:29:42]

LGTM

[eroman, 2010-09-24 22:31:37]

http://codereview.chromium.org/3390026/diff/11001/12057
File tools/sort-headers.py (right):

http://codereview.chromium.org/3390026/diff/11001/12057#newcode83
tools/sort-headers.py:83: #if YesNo('Use new file (y/N)?'):
Please remove this from the CL.

[tfarina, 2010-09-24 22:33:32]

http://codereview.chromium.org/3390026/diff/11001/12057
File tools/sort-headers.py (right):

http://codereview.chromium.org/3390026/diff/11001/12057#newcode83
tools/sort-headers.py:83: #if YesNo('Use new file (y/N)?'):
On 2010/09/24 22:31:37, eroman wrote:
> Please remove this from the CL.
Ops, that was not intended :(

[tfarina, 2010-09-24 22:38:43]

http://codereview.chromium.org/3390026/diff/11001/12057
File tools/sort-headers.py (right):

http://codereview.chromium.org/3390026/diff/11001/12057#newcode83
tools/sort-headers.py:83: #if YesNo('Use new file (y/N)?'):
On 2010/09/24 22:31:37, eroman wrote:
> Please remove this from the CL.

Removed.

[eroman, 2010-09-24 22:42:46]

lgtm