Change NaN-test to only check for QNaNs, and API to only introduce QNaNs.

Change NaN-test to only check for QNaNs, and API to only introduce QNaNs.

[Lasse Reichstein, 2009-10-26 08:33:11]

Small change to disallow Signaling NaNs, and optimize NaN-recognition.
And a test bugfix too.

[Erik Corry, 2009-10-26 08:43:12]

http://codereview.chromium.org/339002/diff/2001/3002
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/339002/diff/2001/3002#newcode7408
Line 7408: __ cmp(eax, 0xFFF00000u);
¿Que?

[Lasse Reichstein, 2009-10-26 08:45:39]

http://codereview.chromium.org/339002/diff/2001/3002
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/339002/diff/2001/3002#newcode7408
Line 7408: __ cmp(eax, 0xFFF00000u);
Stoopid last minute change gone bad.
Fixed to edx.

[Erik Corry, 2009-10-26 08:52:02]

The large hex constants need to be given names.  Eg kQuietNaNMask32
kQuietNaNMask64 and then assert that kQuietNaNMask32 << 1 has the high bit set.

You need an API test that inserts a noisy NaN and then does something with it.

Otherwise LGTM

[Lasse Reichstein, 2009-10-26 12:11:18]

Named constants.
Added test.

[Erik Corry, 2009-10-26 12:21:51]

http://codereview.chromium.org/339002/diff/6001/7003
File src/platform-win32.cc (right):

http://codereview.chromium.org/339002/diff/6001/7003#newcode1336
Line 1336: static const __int64 nanval = 0x7ff8000000000000;
kQuietNaNMask << 32

[Lasse Reichstein, 2009-10-27 08:06:44]

http://codereview.chromium.org/339002/diff/6001/7003
File src/platform-win32.cc (right):

http://codereview.chromium.org/339002/diff/6001/7003#newcode1336
Line 1336: static const __int64 nanval = 0x7ff8000000000000;
Fixed. (Added a 64-bit mask as well, and used it here).