Reuse gcl.py's code review settings when running [gcl try], as gcl is ...

trychange.py

Index: trychange.py
===================================================================
--- trychange.py	(revision 61647)
+++ trychange.py	(working copy)
@@ -33,6 +33,14 @@
 except ImportError:
   pass
 
+# We try to use gcl.py's GetCodeReviewSettings function if available.
+GclGetCodeReviewSetting = None

[M-A Ruel, 2010/10/06 23:43:18]

I'd prefer gcl = None and use if gcl: return gcl.GetCodeReviewSetting(key)
around line 119.

[Jói, 2010/10/06 23:54:03]

Done.

+try:
+  import gcl
+  GclGetCodeReviewSetting = gcl.GetCodeReviewSetting
+except:

[M-A Ruel, 2010/10/06 23:43:18]

except ImportError:

[Jói, 2010/10/06 23:54:03]

Done.

+  pass
+
 import gclient_utils
 import scm
 
@@ -106,17 +114,21 @@
   def GetCodeReviewSetting(self, key):
     """Returns a value for the given key for this repository.
 
-    Uses gcl-style settings from the repository."""
-    if self.codereview_settings is None:
-      self.codereview_settings = {}
-      settings_file = self.ReadRootFile(self.codereview_settings_file)
-      if settings_file:
-        for line in settings_file.splitlines():
-          if not line or line.lstrip().startswith('#'):
-            continue
-          k, v = line.split(":", 1)
-          self.codereview_settings[k.strip()] = v.strip()
-    return self.codereview_settings.get(key, '')
+    Uses gcl-style settings from the repository.
+    """
+    if GclGetCodeReviewSetting:
+      return GclGetCodeReviewSetting(key)
+    else:
+      if self.codereview_settings is None:
+        self.codereview_settings = {}
+        settings_file = self.ReadRootFile(self.codereview_settings_file)
+        if settings_file:
+          for line in settings_file.splitlines():
+            if not line or line.lstrip().startswith('#'):
+              continue
+            k, v = line.split(":", 1)
+            self.codereview_settings[k.strip()] = v.strip()
+      return self.codereview_settings.get(key, '')
 
   def _GclStyleSettings(self):
     """Set default settings based on the gcl-style settings from the