Issue 3389035: r60095 switched cc_infobar_ to be raw pointer but forgot to initialize it....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3389035: r60095 switched cc_infobar_ to be raw pointer but forgot to initialize it.... (Closed)

Created:
10 years, 2 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, ben+cc_chromium.org, James Hawkins, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

r60095 switched cc_infobar_ to be raw pointer but forgot to initialize it. BUG=CID 13105, CID 13106 TEST=dunno Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60716

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/autofill/autofill_manager.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

Doh! LGTM Thanks for fixing it! Please merge it to the M7 branch (or I ...

10 years, 2 months ago (2010-09-27 22:08:03 UTC) #2

Avi (use Gerrit)

10 years, 2 months ago (2010-09-27 22:14:38 UTC) #3

No problem. Coverity found it.

I'll merge.

On Mon, Sep 27, 2010 at 6:08 PM, <jcivelli@chromium.org> wrote:

> Doh!
>
> LGTM
>
> Thanks for fixing it!
> Please merge it to the M7 branch (or I can merge it if you want).
>
>
> http://codereview.chromium.org/3389035/show
>

Expand Messages | Collapse Messages