Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Side by Side Diff: test/mjsunit/regress/regress-52801.js

Issue 3389022: RegExp: Fix caching to correctly set lastIndex. (Closed)
Patch Set: Address review comment. Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/regexp.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // Whenever we enter a with-scope, we copy the context. This in itself is fine
29 // (contexts may escape), but when leaving a with-scope, we currently also copy
30 // the context instead of reverting to the original. This does not work because
31 // inner functions may already have been created using the original context. In
32 // the failing test case below, the inner function is run in the original contex t
33 // (where x is undefined), but the assignment to x after the with-statement is
34 // run in the copied context:
35
36 // RegExp caching doesn't set lastIndex correctly.
37 // See http://code.google.com/p/chromium/issues/detail?id=52801
38
39 var re = /a/g;
40
41 var str = "bbbbabbbbabbbb";
42
43 // Test
44
45 re.test(str);
46 assertEquals(5, re.lastIndex);
47
48 re.lastIndex = 0;
49 re.test(str);
50 assertEquals(5, re.lastIndex); // Fails if caching.
51
52 re.lastIndex = 0;
53 re.test(str);
54 assertEquals(5, re.lastIndex); // Fails if caching.
55
56 // Exec
57
58 re = /a/g;
59
60 re.exec(str);
61 assertEquals(5, re.lastIndex);
62
63 re.lastIndex = 0;
64 re.exec(str);
65 assertEquals(5, re.lastIndex); // Fails if caching.
66
67 re.lastIndex = 0;
68 re.exec(str);
69 assertEquals(5, re.lastIndex); // Fails if caching.
70
71
OLDNEW
« no previous file with comments | « src/regexp.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698