Issue 3389022: RegExp: Fix caching to correctly set lastIndex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3389022: RegExp: Fix caching to correctly set lastIndex. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

RegExp: Fix caching to correctly set lastIndex. BUG: 52801

Patch Set 1 #

Patch Set 2 : Added test. Fix bug. #

Total comments: 1

Patch Set 3 : Address review comment. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -0 lines)			Patch
	M	src/regexp.js	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-52801.js	View		1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 3 months ago (2010-09-22 09:25:54 UTC) #2

LGTM

http://codereview.chromium.org/3389022/diff/2001/3001
File src/regexp.js (right):

http://codereview.chromium.org/3389022/diff/2001/3001#newcode286
src/regexp.js:286: if (this.global) this.lastIndex = lastMatchInfo[CAPTURE1];
We need a little comment here to explain why we only have to do this if the
regexp is global.

Expand Messages | Collapse Messages