Issue 3388005: Make the CompareStub and the UnaryOpStub accept smi inputs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3388005: Make the CompareStub and the UnaryOpStub accept smi inputs.... (Closed)

Created:
10 years, 3 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make the CompareStub and the UnaryOpStub accept smi inputs. The stubs get an additional flag for including the smi code inside the stub. This allows us to generate more compact code if we don't want to inline the smi case outside the stub. Committed: http://code.google.com/p/v8/source/detail?r=5456

Patch Set 1 #

Patch Set 2 : x64 and ARM port #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+392 lines, -151 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	8 chunks	+70 lines, -27 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	7 chunks	+21 lines, -8 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/code-stubs.h	View	5 chunks	+57 lines, -16 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/full-codegen.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	6 chunks	+71 lines, -27 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	8 chunks	+28 lines, -6 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	7 chunks	+19 lines, -7 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+66 lines, -26 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	7 chunks	+28 lines, -5 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	7 chunks	+20 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

This is a new version where I added the x64 and ARM parts.

10 years, 3 months ago (2010-09-15 09:31:45 UTC) #1

Kasper Lund

10 years, 3 months ago (2010-09-15 09:36:11 UTC) #2

LGTM.

http://codereview.chromium.org/3388005/diff/14001/13008
File src/flag-definitions.h (right):

http://codereview.chromium.org/3388005/diff/14001/13008#newcode177
src/flag-definitions.h:177: // full-codegen.cc / full-codegen-ia32.cc
Remove the ia32.cc reference.

Expand Messages | Collapse Messages