Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 3388004: Add support for near labels.... (Closed)

Created:
10 years, 3 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add support for near labels. This change introduces near labels in the assembler, allowing us to uptimize forward jumps (conditional and unconditional) if we can guarantee that the jump is witin range -128 to +127. I changed a large fractions of the existing Labels to NearLabels, and left out cases where it was not immediately clear if it could be used or not (not immediately clear means labels covering a large code block, or used in function calls which we could potentially change to accept near labels). Committed: http://code.google.com/p/v8/source/detail?r=5460

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -141 lines) Patch
M src/assembler.h View 1 chunk +51 lines, -0 lines 1 comment Download
M src/ia32/assembler-ia32.h View 4 chunks +8 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 3 chunks +52 lines, -26 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 46 chunks +51 lines, -51 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 19 chunks +22 lines, -19 lines 0 comments Download
M src/x64/assembler-x64.h View 4 chunks +8 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +54 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 28 chunks +30 lines, -30 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 13 chunks +13 lines, -13 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Rico
10 years, 3 months ago (2010-09-15 10:03:37 UTC) #1
Søren Thygesen Gjesse
Drive by comment http://codereview.chromium.org/3388004/diff/1/2 File src/assembler.h (right): http://codereview.chromium.org/3388004/diff/1/2#newcode100 src/assembler.h:100: class NearLabel BASE_EMBEDDED { How about ...
10 years, 3 months ago (2010-09-15 10:38:20 UTC) #2
fschneider
LGTM. http://codereview.chromium.org/3388004/diff/1/10 File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/3388004/diff/1/10#newcode681 src/x64/full-codegen-x64.cc:681: Label slow_case; Indentation off. I think this can ...
10 years, 3 months ago (2010-09-15 11:21:08 UTC) #3
Rico
10 years, 3 months ago (2010-09-15 11:33:29 UTC) #4
I will refactor the NearLabel class in another change.

http://codereview.chromium.org/3388004/diff/1/10
File src/x64/full-codegen-x64.cc (right):

http://codereview.chromium.org/3388004/diff/1/10#newcode681
src/x64/full-codegen-x64.cc:681: Label slow_case;
On 2010/09/15 11:21:08, fschneider wrote:
> Indentation off. I think this can be a NearLabel too.
Actually no, JumpIfNotBothSmi takes a Label

Powered by Google App Engine
This is Rietveld 408576698