Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 3387018: The return value of ClosePlatformFile() was reversed in r59041. Most... (Closed)

Created:
10 years, 2 months ago by dumi
Modified:
9 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

The return value of ClosePlatformFile() was reversed in r59041. Most calls to ClosePlatformFile() ignore the return value, but there are two calls that do use it: 1. webkit/glue/webfileutilities_impl.cc, closeFile() method: i talked to jianli who changed that method most recently, and he said he prefers the handle to be reset to base::kInvalidPlatformFileValue if ClosePlatformFile() succeeded, so no change is needed to that code. 2. webkit/database/database_tracker.cc, CloseIncognitoFileHandle(): this code needs to be updated. TEST=WebSQLDBs don't crash in incognito mode. BUG=56237 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/platform_file.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dumi
10 years, 2 months ago (2010-09-24 23:08:49 UTC) #1
michaeln
10 years, 2 months ago (2010-09-24 23:13:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698