Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 3387009: Be lenient if deconfig fails to find a bridge (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler, DaleCurtis
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Be lenient if deconfig fails to find a bridge If we are in the deconfig step, it is acceptable if brctl cannot find the bridge it was trying to delete. BUG=none TEST=run_wifi_tests on SecMat

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M server/site_linux_router.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-18 02:08:18 UTC) #1
Sam Leffler
Why would the bridge not be there?
10 years, 3 months ago (2010-09-18 19:46:58 UTC) #2
Paul Stewart
On 2010/09/18 19:46:58, Sam Leffler wrote: > Why would the bridge not be there? Depending ...
10 years, 3 months ago (2010-09-21 18:56:09 UTC) #3
DaleCurtis
LGTM On 2010/09/21 18:56:09, Paul Stewart wrote: > On 2010/09/18 19:46:58, Sam Leffler wrote: > ...
10 years, 3 months ago (2010-09-21 19:00:03 UTC) #4
Sam Leffler
10 years, 3 months ago (2010-09-21 19:09:02 UTC) #5
I'm ok w/ ignoring the error but it seems like the real problem is we don't
cleanup properly.

Powered by Google App Engine
This is Rietveld 408576698