Pull latest PPAPI. Change support for key handling.

Pull latest PPAPI. Change key handling to support the new API.

TEST=PPAPI UI tests
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60258

[wjia(left Chromium), 2010-09-22 00:58:12]

http://codereview.chromium.org/3386019/diff/8001/9001
File webkit/glue/plugins/pepper_event_conversion.cc (right):

http://codereview.chromium.org/3386019/diff/8001/9001#newcode59
webkit/glue/plugins/pepper_event_conversion.cc:59: return result;
This means a copy when this function is returned. Using reference as an argument
can save the copying.

http://codereview.chromium.org/3386019/diff/8001/9001#newcode87
webkit/glue/plugins/pepper_event_conversion.cc:87: 
These 2 while loops could be merged.

http://codereview.chromium.org/3386019/diff/8001/9001#newcode174
webkit/glue/plugins/pepper_event_conversion.cc:174: string16 text16 =
UTF8ToUTF16(std::string(event.u.character.text, text_len));
looks like text16 is not used.

http://codereview.chromium.org/3386019/diff/8001/9003
File webkit/glue/plugins/pepper_plugin_instance.cc (right):

http://codereview.chromium.org/3386019/diff/8001/9003#newcode459
webkit/glue/plugins/pepper_plugin_instance.cc:459: rv |=
instance_interface_->HandleInputEvent(GetPPInstance(), &pp_events[i]);
would it be "rv &= instance_interface_->HandleInputEvent(...)" with rv set to
true initially? In other words, if any event is not handled by plugin, we'd
return false, right?

[brettw, 2010-09-22 19:39:08]

Please take another look

http://codereview.chromium.org/3386019/diff/8001/9001
File webkit/glue/plugins/pepper_event_conversion.cc (right):

http://codereview.chromium.org/3386019/diff/8001/9001#newcode59
webkit/glue/plugins/pepper_event_conversion.cc:59: return result;
This data should be reasonably efficient to copy and input events are not very
time critical, so I prefer the readability. Plus, in this case, the compiler can
generally do return value optimization and there won't even be a copy. We
generally prefer to return relatively simple things for the readability reasons,
even std::strings in Chrome.

http://codereview.chromium.org/3386019/diff/8001/9001#newcode87
webkit/glue/plugins/pepper_event_conversion.cc:87: 
The CharIterator needs to know the last character (the reason for all of this is
I want to handle non-BMP characters which might be >1 16-bit character).

http://codereview.chromium.org/3386019/diff/8001/9003
File webkit/glue/plugins/pepper_plugin_instance.cc (right):

http://codereview.chromium.org/3386019/diff/8001/9003#newcode459
webkit/glue/plugins/pepper_plugin_instance.cc:459: rv |=
instance_interface_->HandleInputEvent(GetPPInstance(), &pp_events[i]);
I think the current code is better. Having more than one event is quite uncommon
and will happen only on Mac (currently). The main thing is controlling whether
we want that original event to bubble. I think if the plugin consumes any
character of the multi-character event, then we do not want that to bubble or
you'll get duplicated events. In the current code, the opposite will happen, but
I think that's the plugin's fault that they didn't accept one of the characters.

[wjia(left Chromium), 2010-09-22 19:45:38]

LGTM.