chrome/browser/extensions/extension_crash_recovery_browsertest.cc - Issue 3386014: This adds some plumbing for propagating the status and error code of a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 3386014: This adds some plumbing for propagating the status and error code of a (Closed)

Patch Set: Fixed Mac code to handle both SEGV and BUS Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

index 32b67af76561ed31ec96d254f9bee4a6edac1d0a..4518569fe03e1e68d0711d302b32149f3d217dce 100644

--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

@@ -61,7 +61,7 @@ class ExtensionCrashRecoveryTest : public ExtensionBrowserTest {

RenderProcessHost* extension_rph =

extension_host->render_view_host()->process();

base::KillProcess(extension_rph->GetHandle(),

- base::PROCESS_END_KILLED_BY_USER, false);

+ base::TERMINATION_STATUS_PROCESS_WAS_KILLED, false);

ASSERT_TRUE(WaitForExtensionCrash(extension_id));

ASSERT_FALSE(

GetExtensionProcessManager()->GetBackgroundHostForExtension(extension));