Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Side by Side Diff: chrome/browser/tab_contents/interstitial_page.cc

Issue 3386014: This adds some plumbing for propagating the status and error code of a (Closed)
Patch Set: Fixed Mac code to handle both SEGV and BUS Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/interstitial_page.h" 5 #include "chrome/browser/tab_contents/interstitial_page.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/thread.h" 10 #include "base/thread.h"
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 } 316 }
317 317
318 RenderViewHostDelegate::View* InterstitialPage::GetViewDelegate() { 318 RenderViewHostDelegate::View* InterstitialPage::GetViewDelegate() {
319 return rvh_view_delegate_.get(); 319 return rvh_view_delegate_.get();
320 } 320 }
321 321
322 const GURL& InterstitialPage::GetURL() const { 322 const GURL& InterstitialPage::GetURL() const {
323 return url_; 323 return url_;
324 } 324 }
325 325
326 void InterstitialPage::RenderViewGone(RenderViewHost* render_view_host) { 326 void InterstitialPage::RenderViewGone(RenderViewHost* render_view_host,
327 base::TerminationStatus status,
328 int error_code) {
327 // Our renderer died. This should not happen in normal cases. 329 // Our renderer died. This should not happen in normal cases.
328 // Just dismiss the interstitial. 330 // Just dismiss the interstitial.
329 DontProceed(); 331 DontProceed();
330 } 332 }
331 333
332 void InterstitialPage::DidNavigate( 334 void InterstitialPage::DidNavigate(
333 RenderViewHost* render_view_host, 335 RenderViewHost* render_view_host,
334 const ViewHostMsg_FrameNavigate_Params& params) { 336 const ViewHostMsg_FrameNavigate_Params& params) {
335 // A fast user could have navigated away from the page that triggered the 337 // A fast user could have navigated away from the page that triggered the
336 // interstitial while the interstitial was loading, that would have disabled 338 // interstitial while the interstitial was loading, that would have disabled
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 } 675 }
674 676
675 void InterstitialPage::InterstitialPageRVHViewDelegate::OnFindReply( 677 void InterstitialPage::InterstitialPageRVHViewDelegate::OnFindReply(
676 int request_id, int number_of_matches, const gfx::Rect& selection_rect, 678 int request_id, int number_of_matches, const gfx::Rect& selection_rect,
677 int active_match_ordinal, bool final_update) { 679 int active_match_ordinal, bool final_update) {
678 } 680 }
679 681
680 int InterstitialPage::GetBrowserWindowID() const { 682 int InterstitialPage::GetBrowserWindowID() const {
681 return tab_->GetBrowserWindowID(); 683 return tab_->GetBrowserWindowID();
682 } 684 }
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/interstitial_page.h ('k') | chrome/browser/tab_contents/web_contents_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698