Issue 3386007: AU: when compiling locally, use cros-debug for libchrome

Issue 3386007: AU: when compiling locally, use cros-debug for libchrome (Closed)

Created:
10 years, 3 months ago by adlr

Modified:
9 years ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@chromiumos-git/update_engine.git

Visibility:
Public.

Description

AU: when compiling locally, use cros-debug for libchrome BUG=6797 TEST=compiled locally. saw this fix the error

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	setup_dev_packages	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM, although I haven't looked at this script before and don't know what it's supposed ...

10 years, 3 months ago (2010-09-16 22:57:24 UTC) #2

adlr

On Thu, Sep 16, 2010 at 3:57 PM, <derat@chromium.org> wrote: > LGTM, although I haven't ...

10 years, 3 months ago (2010-09-16 22:59:14 UTC) #3

Daniel Erat

Hmm, but shouldn't you be picking up cros-debug automatically? I made it on by default.

10 years, 3 months ago (2010-09-16 23:01:38 UTC) #4

adlr

A tester ran into the link error with a chroot made today. Perhaps b/c we ...

10 years, 3 months ago (2010-09-16 23:05:20 UTC) #5

Daniel Erat

10 years, 3 months ago (2010-09-17 00:07:20 UTC) #6

Hmm, dunno.  Anyway, seems safe enough to me.

On Thu, Sep 16, 2010 at 4:04 PM, Andrew de los Reyes <adlr@chromium.org> wrote:
> A tester ran into the link error with a chroot made today. Perhaps b/c we
> specify our own USE flags in this file didn't pick it up?
>
> On Thu, Sep 16, 2010 at 4:01 PM, <derat@chromium.org> wrote:
>>
>> Hmm, but shouldn't you be picking up cros-debug automatically?  I made it
>> on by
>> default.
>>
>> http://codereview.chromium.org/3386007/show
>
>

Expand Messages | Collapse Messages