Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 3384035: Printing: Call PrintingContext::AskUserForSettings() on the UI thread for Linux (Closed)

Created:
10 years, 2 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Printing: Call PrintingContext::AskUserForSettings() on the UI thread for Linux as well, because gtk cannot be called on a non-UI thread. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/printing/print_job_worker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
10 years, 2 months ago (2010-09-27 23:08:36 UTC) #1
stuartmorgan
10 years, 2 months ago (2010-09-27 23:18:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698