Issue 3384032: Only check the well-known password if we know it is not owned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3384032: Only check the well-known password if we know it is not owned. (Closed)

Created:
10 years, 2 months ago by fes

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato, DaleCurtis

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/tpm_init.git

Visibility:
Public.

Description

Only check the well-known password if we know it is not owned. This fix ensures that we only try the well-known owner password if the TPM is not fully owned by checking for the presence of the .tpm_owned file. Otherwise, each boot would cause a failed password attempt, which, on some TPMs, can eventually get the TPM into defend lock state. Change-Id: I87ef8028ed61f20e80e0d65a4e4d84cceea10203 BUG=partner/1137 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e6f904

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tpm.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2010/09/27 19:22:30, fes wrote:
>

Expand Messages | Collapse Messages