Issue 3384024: sync_unit_tests: add test for unknown field retention.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3384024: sync_unit_tests: add test for unknown field retention. (Closed)

Created:
10 years, 2 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow), akalin

CC:
chromium-reviews, ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)

Visibility:
Public.

Description

sync_unit_tests: add test for unknown field retention. Retaining unknown fields is important for the sync protocol, so it's good to test that it's working. In the future, when we hopefully have a lite runtime with retention abilities, this test will make sure that we haven't broken anything. BUG=56579 TEST=sync_unit_tests

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -0 lines)			Patch
M	chrome/browser/sync/protocol/sync_proto.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/sync/protocol/test.proto	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/util/protobuf_unittest.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

10 years, 2 months ago (2010-09-24 22:29:33 UTC) #3

LGTM

On 2010/09/24 17:20:07, ncarter wrote:
> LGTM.  I'm delighted to have this test.

Expand Messages | Collapse Messages