Issue 3384020: Improve breakpad by adding cwd, fix str(last_tb) and dump what is sent to the user.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3384020: Improve breakpad by adding cwd, fix str(last_tb) and dump what is sent to the user. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Improve breakpad by adding cwd, fix str(last_tb) and dump what is sent to the user. The user will get an idea of what data is sent. Getting the current working directory is useful to know what checkout was used. the repr(last_tb) call was stripping off a lot of useful information for debugging. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60339

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	breakpad.py	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

On 2010/09/23 20:24:14, bradn wrote: > LGTM, maybe commment why 50? Bah it's just to ...

10 years, 3 months ago (2010-09-23 20:25:47 UTC) #4

bradn

10 years, 3 months ago (2010-09-23 20:27:36 UTC) #5

Eh, whichever.

On Thu, Sep 23, 2010 at 1:25 PM, <maruel@chromium.org> wrote:

> On 2010/09/23 20:24:14, bradn wrote:
>
>> LGTM, maybe commment why 50?
>>
>
> Bah it's just to strip off long lines, I'm not sure it's worth adding
> anything
> there?
>
>
> http://codereview.chromium.org/3384020/show
>

Expand Messages | Collapse Messages