Issue 3384019: Fix Win64 build with VS2008.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3384019: Fix Win64 build with VS2008. (Closed)

Created:
10 years, 3 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Fix Win64 build with VS2008. strlen returns size_t and VS2008 is now pretty picky about that. Committed: http://code.google.com/p/v8/source/detail?r=5506

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moving to StrLength instead of static_cast #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	test/cctest/test-parsing.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

10 years, 3 months ago (2010-09-22 12:56:53 UTC) #2

LGTM

http://codereview.chromium.org/3384019/diff/1/2
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/3384019/diff/1/2#newcode159
test/cctest/test-parsing.cc:159: tests[i], static_cast<int>(strlen(tests[i])));
Could we use StrLength instead (which returns int)? (everywhere).

Expand Messages | Collapse Messages