Issue 3384001: The LSID for Cloud Print can now be supplied on the command line even if Clou...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3384001: The LSID for Cloud Print can now be supplied on the command line even if Clou... (Closed)

Created:
10 years, 3 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
Scott Byer

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The LSID for Cloud Print can now be supplied on the command line even if Cloud Print was previously enabled. This had broken during a recent change to remember the enabled state of Cloud Print in the service process. BUG=None TEST=With cloud print previously enabled, try launching the service process with a new LSID in the command line. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59387

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -21 lines)			Patch
M	chrome/service/service_main.cc	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/service/service_process.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/service/service_process.cc	View	3 chunks	+18 lines, -8 lines	0 comments	Download
M	chrome/service/service_process_unittest.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages