Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 3383008: Reland r59641. Add the onBeforeNavigate and onErrorOccured events to the webNavigation API. (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Reland r59641. Add the onBeforeNavigate and onErrorOccured events to the webNavigation API. Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered. BUG=50943 TEST=WebNavigationEvents Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -99 lines) Patch
M chrome/browser/extensions/extension_webnavigation_api.h View 2 chunks +21 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 4 chunks +74 lines, -13 lines 0 comments Download
M chrome/browser/tab_contents/provisional_load_details.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/provisional_load_details.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/navigation/test.html View 1 chunk +201 lines, -78 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698