Issue 3383006: Create safe_browsing_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3383006: Create safe_browsing_tests (Closed)

Created:
10 years, 3 months ago by lzheng

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Create test for safebrowsing_test TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59865

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -219 lines)			Patch
M	build/all.gyp	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_browsertest.cc	View	1 2	1 chunk	+0 lines, -219 lines	0 comments	Download
A +	chrome/browser/safe_browsing/safe_browsing_test.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+33 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

lzheng

Nicolas: This seems to be the least dependencies I could put in the .gyi for ...

10 years, 3 months ago (2010-09-17 17:13:46 UTC) #1

nsylvain

this looks good to me, but i am not a gyp expert. If you want ...

10 years, 3 months ago (2010-09-17 18:47:55 UTC) #2

lzheng1

Nicolas: I updated all.gyp. Another look? I am not sure how to test my change ...

10 years, 3 months ago (2010-09-17 19:19:16 UTC) #3

nsylvain

10 years, 3 months ago (2010-09-17 19:57:56 UTC) #4

lgtm.   build the "chromium_browser" project in all.sln to tests it. but i'm
pretty confident it will work.