Add libsrtp in DEPS, gyp file for libsrtp.

Add libsrtp in DEPS, gyp file for libsrtp.

BUG=53986
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60213

[Sergey Ulanov, 2010-09-21 18:59:26]

Do I also need to update chrome/browser/resources/about_credits.html, or is it
updated automatically?

[Evan Martin, 2010-09-21 19:20:00]

about:credits is manually updated.  I would say don't worry about it, and I will
get around to updating it when I get the chance.

http://codereview.chromium.org/3382013/diff/2001/3001
File DEPS (right):

http://codereview.chromium.org/3382013/diff/2001/3001#newcode179
DEPS:179: "src/third_party/libsrtp/source":
Can you make it "src" instead of "source"?  That's what's used elsewhere.

http://codereview.chromium.org/3382013/diff/2001/3003
File third_party/libsrtp/README.chromium (right):

http://codereview.chromium.org/3382013/diff/2001/3003#newcode3
third_party/libsrtp/README.chromium:3: License File: source/LICENSE
src/

http://codereview.chromium.org/3382013/diff/2001/3003#newcode5
third_party/libsrtp/README.chromium:5: libSRTP used by Chrome. See
source/README.chromium for about current revision.
Oh, someone else gave you bad advice in the previous review.  :(

The reason to have this extra layer of directories (third_party/libsrtp vs
third_party/libsrtp/src) is so we can leave the src/ subdir unmodified...
Probably not worth fixing at this point.

http://codereview.chromium.org/3382013/diff/2001/3004
File third_party/libsrtp/config/config.h (right):

http://codereview.chromium.org/3382013/diff/2001/3004#newcode6
third_party/libsrtp/config/config.h:6: // build is configured by libsrtp.gyp.
Why is it needed?

http://codereview.chromium.org/3382013/diff/2001/3005
File third_party/libsrtp/libsrtp.gyp (right):

http://codereview.chromium.org/3382013/diff/2001/3005#newcode20
third_party/libsrtp/libsrtp.gyp:20: 'FIXME',
?

http://codereview.chromium.org/3382013/diff/2001/3005#newcode27
third_party/libsrtp/libsrtp.gyp:27: '_DEBUG',
Is this needed in all dependents?

[Sergey Ulanov, 2010-09-21 23:06:13]

http://codereview.chromium.org/3382013/diff/2001/3001
File DEPS (right):

http://codereview.chromium.org/3382013/diff/2001/3001#newcode179
DEPS:179: "src/third_party/libsrtp/source":
On 2010/09/21 19:20:02, Evan Martin wrote:
> Can you make it "src" instead of "source"?  That's what's used elsewhere.
Done. BTW, ffmpeg and libjingle (mine) still use source.

http://codereview.chromium.org/3382013/diff/2001/3003
File third_party/libsrtp/README.chromium (right):

http://codereview.chromium.org/3382013/diff/2001/3003#newcode3
third_party/libsrtp/README.chromium:3: License File: source/LICENSE
On 2010/09/21 19:20:02, Evan Martin wrote:
> src/

Done.

http://codereview.chromium.org/3382013/diff/2001/3004
File third_party/libsrtp/config/config.h (right):

http://codereview.chromium.org/3382013/diff/2001/3004#newcode6
third_party/libsrtp/config/config.h:6: // build is configured by libsrtp.gyp.
On 2010/09/21 19:20:02, Evan Martin wrote:
> Why is it needed?
Because config.h is included from some sources. Normally config.h is generated
by configure script, but we don't use it here, so we need some replacement for
config.h.

http://codereview.chromium.org/3382013/diff/2001/3005
File third_party/libsrtp/libsrtp.gyp (right):

http://codereview.chromium.org/3382013/diff/2001/3005#newcode20
third_party/libsrtp/libsrtp.gyp:20: 'FIXME',
On 2010/09/21 19:20:02, Evan Martin wrote:
> ?
Removed

http://codereview.chromium.org/3382013/diff/2001/3005#newcode27
third_party/libsrtp/libsrtp.gyp:27: '_DEBUG',
On 2010/09/21 19:20:02, Evan Martin wrote:
> Is this needed in all dependents?
Removed

[Evan Martin, 2010-09-22 00:06:04]

LGTM with minor nits fixed below

http://codereview.chromium.org/3382013/diff/10001/11003
File third_party/libsrtp/README.chromium (right):

http://codereview.chromium.org/3382013/diff/10001/11003#newcode5
third_party/libsrtp/README.chromium:5: libSRTP used by Chrome. See
source/README.chromium for about current revision.
Would you mind elaborating a bit on what this is?
It's hopefully obvious that it's used by Chrome because it's in the tree.  It
seems to be used by chromoting or something?

http://codereview.chromium.org/3382013/diff/10001/11005
File third_party/libsrtp/libsrtp.gyp (right):

http://codereview.chromium.org/3382013/diff/10001/11005#newcode19
third_party/libsrtp/libsrtp.gyp:19: },
I guess this block is no longer needed now?

http://codereview.chromium.org/3382013/diff/10001/11005#newcode42
third_party/libsrtp/libsrtp.gyp:42: ['OS=="linux" or OS=="mac" or OS=="freebsd"
or OS=="openbsd"', {
This could maybe be
  OS!="win"
?

[Sergey Ulanov, 2010-09-22 01:24:34]

http://codereview.chromium.org/3382013/diff/10001/11003
File third_party/libsrtp/README.chromium (right):

http://codereview.chromium.org/3382013/diff/10001/11003#newcode5
third_party/libsrtp/README.chromium:5: libSRTP used by Chrome. See
source/README.chromium for about current revision.
On 2010/09/22 00:06:04, Evan Martin wrote:
> Would you mind elaborating a bit on what this is?
> It's hopefully obvious that it's used by Chrome because it's in the tree.  It
> seems to be used by chromoting or something?

Done.

http://codereview.chromium.org/3382013/diff/10001/11005
File third_party/libsrtp/libsrtp.gyp (right):

http://codereview.chromium.org/3382013/diff/10001/11005#newcode19
third_party/libsrtp/libsrtp.gyp:19: },
On 2010/09/22 00:06:04, Evan Martin wrote:
> I guess this block is no longer needed now?

Done.

http://codereview.chromium.org/3382013/diff/10001/11005#newcode42
third_party/libsrtp/libsrtp.gyp:42: ['OS=="linux" or OS=="mac" or OS=="freebsd"
or OS=="openbsd"', {
On 2010/09/22 00:06:04, Evan Martin wrote:
> This could maybe be
>   OS!="win"
> ?

Done.