Issue 3382002: Make data_display_geometry as a check item in hardware component test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3382002: Make data_display_geometry as a check item in hardware component test. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Hung-Te, Nick Sanders, nsanders, Bill Richardson

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Make data_display_geometry as a check item in hardware component test. It can ensure that the recovery BMPs contain the same size as display. TEST=run the hardware_Components test in non-Mario. Manually change the output to [] and ['1280x800', '1234x567'] to test. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c261839

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
	M	client/site_tests/hardware_Components/hardware_Components.py	View		4 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM except one concern. I thought "display geometry" was used to locate where to print ...

10 years, 3 months ago (2010-09-16 04:07:19 UTC) #2

nsanders

10 years, 3 months ago (2010-09-16 04:37:03 UTC) #3

lgtm

> I thought "display geometry" was used to locate where to print the recovery
URL
> / HWID in recovery screen, but in this CL it seems to describe the size of
> display panel. Are you sure this is what we want?

It's both: the image is scaled from the native display size to the bios vga size
so that the aspect ratio and positioning are correct when displayed.

Expand Messages | Collapse Messages