Issue 3381027: Fix nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3381027: Fix nits (Closed)

Created:
10 years, 2 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews

Visibility:
Public.

Description

Fix nits BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60715

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	skia/ext/SkThread_chrome.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

10 years, 2 months ago (2010-09-27 20:51:49 UTC) #2

LGTM
this was a tough one alright :)

On Mon, Sep 27, 2010 at 1:39 PM, <piman@chromium.org> wrote:

> Reviewers: timsteele,
>
> Description:
> Fix nits
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3381027/show
>
> Affected files:
>  M skia/ext/SkThread_chrome.cc
>
>
> Index: skia/ext/SkThread_chrome.cc
> diff --git a/skia/ext/SkThread_chrome.cc b/skia/ext/SkThread_chrome.cc
> index
>
469330955df692b6c183c687dd79afcd31069a46..98375fa66ce54e6d52753b6d452bb2d92a473477
> 100644
> --- a/skia/ext/SkThread_chrome.cc
> +++ b/skia/ext/SkThread_chrome.cc
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +// Copyright (c) 2010 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> @@ -18,7 +18,7 @@ int32_t sk_atomic_inc(int32_t* addr) {
>  }
>
>  int32_t sk_atomic_dec(int32_t* addr) {
> -  // sk_atomic_inc is expected to return the old value,
> Barrier_AtomicIncrement
> +  // sk_atomic_dec is expected to return the old value,
> Barrier_AtomicIncrement
>   // returns the new value.
>   return base::subtle::Barrier_AtomicIncrement(addr, -1) + 1;
>  }
>
>
>

Expand Messages | Collapse Messages