Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 3381013: Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug. (Closed)

Created:
10 years, 3 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug. Test was failing is due to a fact that MSVC in debug mode uses separate instances for identical string literals. TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=5496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M test/cctest/test-profile-generator.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 3 months ago (2010-09-20 12:24:53 UTC) #1
Søren Thygesen Gjesse
10 years, 3 months ago (2010-09-20 13:11:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698