Issue 3381005: X64: Templating Smi-macros to use both Label and NearLabel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3381005: X64: Templating Smi-macros to use both Label and NearLabel. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

X64: Templating Smi-macros to use both Label and NearLabel. Added some more uses of NearLabel.

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+834 lines, -741 lines)			Patch
M	src/x64/code-stubs-x64.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	7 chunks	+7 lines, -6 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	12 chunks	+778 lines, -31 lines	2 comments	Download
M	src/x64/macro-assembler-x64.cc	View	24 chunks	+45 lines, -699 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM, but why are all the method implementations moved from macro-assembler-x64.cc to the header file? ...

10 years, 3 months ago (2010-09-16 06:32:15 UTC) #2

Lasse Reichstein

10 years, 3 months ago (2010-09-16 07:03:07 UTC) #3

The functions are moved to the .h file because they are templates.

http://codereview.chromium.org/3381005/diff/1/5
File src/x64/macro-assembler-x64.h (right):

http://codereview.chromium.org/3381005/diff/1/5#newcode1017
src/x64/macro-assembler-x64.h:1017: ASSERT_EQ(0, kSmiTag);
Nor is the function.
Function removed.

Expand Messages | Collapse Messages