Update the unit test to test the FLIP client writes as well...

Update the unit test to test the FLIP client writes as well
as the FLIP client reads.  Then, enable the use of the 
CONTROL_FLAG_FIN on a request which has no data.

Added a new test for a POST.  The test passes today, but I
will make it stronger with my next pass at fully implementing
POST.

POST uploads are still not complete

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30342

[wtc, 2009-10-28 00:56:13]

LGTM.

http://codereview.chromium.org/338055/diff/2010/2013
File net/flip/flip_network_transaction_unittest.cc (right):

http://codereview.chromium.org/338055/diff/2010/2013#newcode189
Line 189: MockWrite(true, 0, 0),  // EOF
Do we really need this MockWrite entry for EOF?

http://codereview.chromium.org/338055/diff/2010/2013#newcode213
Line 213: const char upload[] = { "hello world" };
Nit: add "static".

http://codereview.chromium.org/338055/diff/2010/2013#newcode291
Line 291: 
Did you mean to add this blank line and the blank line below
at line 321?

http://codereview.chromium.org/338055/diff/2010/2012
File net/flip/flip_session.h (right):

http://codereview.chromium.org/338055/diff/2010/2012#newcode115
Line 115: friend class net::FlipNetworkTransactionTest;
Nit: We don't need net:: because this is in the net namespace.

[Mike Belshe, 2009-10-28 01:02:33]

http://codereview.chromium.org/338055/diff/2010/2013
File net/flip/flip_network_transaction_unittest.cc (right):

http://codereview.chromium.org/338055/diff/2010/2013#newcode189
Line 189: MockWrite(true, 0, 0),  // EOF
No - turns out we don't.

On 2009/10/28 00:56:13, wtc wrote:
> Do we really need this MockWrite entry for EOF?

http://codereview.chromium.org/338055/diff/2010/2013#newcode213
Line 213: const char upload[] = { "hello world" };
On 2009/10/28 00:56:13, wtc wrote:
> Nit: add "static".

Done.

http://codereview.chromium.org/338055/diff/2010/2013#newcode291
Line 291: 
On 2009/10/28 00:56:13, wtc wrote:
> Did you mean to add this blank line and the blank line below
> at line 321?

Done.

http://codereview.chromium.org/338055/diff/2010/2012
File net/flip/flip_session.h (right):

http://codereview.chromium.org/338055/diff/2010/2012#newcode115
Line 115: friend class net::FlipNetworkTransactionTest;
On 2009/10/28 00:56:13, wtc wrote:
> Nit: We don't need net:: because this is in the net namespace.

Done.

[wtc, 2009-10-28 01:12:05]

LGTM.

http://codereview.chromium.org/338055/diff/1006/1009
File net/flip/flip_network_transaction_unittest.cc (right):

http://codereview.chromium.org/338055/diff/1006/1009#newcode318
Line 318: 
Please delete this blank line, too.