Checking in checkbin.py, a tool to make sure our Windows binaries were built correctly.

Checking in checkbin.py, a tool to make sure our Windows binaries were built correctly.

It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries.

BUG=25952
TEST=try running it on the output of /src/chrome/Debug

[scherkus (not reviewing), 2009-10-27 21:28:33]

I don't have python readability and this is my first time hacking on something
under /tools

Please feel free to rip it apart, suggest a different name, different location
for the tool, etc...

[M-A Ruel, 2009-10-27 23:38:39]

checkbin.sh wasn't uploaded.

http://codereview.chromium.org/338052/diff/1001/2002
File tools/checkbin/checkbin.bat (right):

http://codereview.chromium.org/338052/diff/1001/2002#newcode1
Line 1: @set PYTHONPATH=%~dp0..\..\third_party\pefile
@echo off
setlocal

http://codereview.chromium.org/338052/diff/1001/2003
File tools/checkbin/checkbin.py (right):

http://codereview.chromium.org/338052/diff/1001/2003#newcode14
Line 14: import optparse
you don't use optparse

http://codereview.chromium.org/338052/diff/1001/2003#newcode35
Line 35: print "Checking %s..." % path
I think it should be silent by default, maybe you could use optparse to support
--verbose. :)

[scherkus (not reviewing), 2009-10-28 00:50:27]

gah.. rietveld isn't showing my checkbin.sh

could you view it from here instead:
http://codereview.chromium.org/download/issue338052_8001_8005.diff

http://codereview.chromium.org/338052/diff/1001/2002
File tools/checkbin/checkbin.bat (right):

http://codereview.chromium.org/338052/diff/1001/2002#newcode1
Line 1: @set PYTHONPATH=%~dp0..\..\third_party\pefile
On 2009/10/27 23:38:39, Marc-Antoine Ruel wrote:
> @echo off
> setlocal

Done.

http://codereview.chromium.org/338052/diff/1001/2003
File tools/checkbin/checkbin.py (right):

http://codereview.chromium.org/338052/diff/1001/2003#newcode14
Line 14: import optparse
On 2009/10/27 23:38:39, Marc-Antoine Ruel wrote:
> you don't use optparse

Done.

http://codereview.chromium.org/338052/diff/1001/2003#newcode35
Line 35: print "Checking %s..." % path
On 2009/10/27 23:38:39, Marc-Antoine Ruel wrote:
> I think it should be silent by default, maybe you could use optparse to
support
> --verbose. :)

sounds good :)

[M-A Ruel, 2009-10-28 01:03:55]

lgtm

http://codereview.chromium.org/338052/diff/8001/8003
File tools/checkbin/checkbin.bat (right):

http://codereview.chromium.org/338052/diff/8001/8003#newcode4
Line 4: %~dp0\..\..\third_party\python_24\python.exe %~dp0\checkbin.py %*
%~dp0..\..\third_party\python_24\python.exe %~dp0checkbin.py %*

[scherkus (not reviewing), 2009-10-28 01:12:41]

so now that I'll check this in, what are the next steps for getting it running
on windows bots?  I was thinking the full builder, both chromium and
branded/Google Chrome (since our avcodec dlls will be different)

http://codereview.chromium.org/338052/diff/8001/8003
File tools/checkbin/checkbin.bat (right):

http://codereview.chromium.org/338052/diff/8001/8003#newcode4
Line 4: %~dp0\..\..\third_party\python_24\python.exe %~dp0\checkbin.py %*
On 2009/10/28 01:03:55, Marc-Antoine Ruel wrote:
> %~dp0..\..\third_party\python_24\python.exe %~dp0checkbin.py %*

Done.

[M-A Ruel, 2009-10-28 01:18:11]

On 2009/10/28 01:12:41, scherkus wrote:
> so now that I'll check this in, what are the next steps for getting it running
> on windows bots?  I was thinking the full builder, both chromium and
> branded/Google Chrome (since our avcodec dlls will be different)

http://dev.chromium.org/developers/testing/chromium-build-infrastructure/gett...