Adds UI components for desktop notifications, including balloon view classes ...

Adds UI components for desktop notifications, including balloon view classes to display toasts on the screen, and manager for controlling the layout of the balloons.

BUG=none
TEST=none yet (part of larger patch)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30471

[John Gregg, 2009-10-27 21:08:55]

With the underlying changes to the widget code checked in, here's a new patch
for notifications UI.  I separated out the non-UI code (i.e., hooking this stuff
up to BrowserProcess) to make this patch more compact.

[Ben Goodger (Google), 2009-10-28 18:56:16]

http://codereview.chromium.org/338051/diff/34/44
File chrome/browser/notifications/balloon_collection.cc (right):

http://codereview.chromium.org/338051/diff/34/44#newcode56
Line 56: int current_max_length = max_balloon_length * count();
I thought you were going to change these to "size"?

http://codereview.chromium.org/338051/diff/34/45
File chrome/browser/notifications/balloon_collection.h (right):

http://codereview.chromium.org/338051/diff/34/45#newcode121
Line 121: HORIZONTALLY_FROM_BOTTOM_LEFT,
Are we actually going to use these horizontal modes? I mentioned this to
glen/cole and they saw no use for them.

http://codereview.chromium.org/338051/diff/34/43
File chrome/browser/views/notifications/balloon_view_host_win.cc (right):

http://codereview.chromium.org/338051/diff/34/43#newcode77
Line 77: RenderWidgetHostViewWin* view = new RenderWidgetHostViewWin(rvh);
It hurts me that we have this whole file because this construction and the HWND
creation below is windows-specific. Can you improve this?

[John Gregg, 2009-10-28 19:16:55]

http://codereview.chromium.org/338051/diff/34/44
File chrome/browser/notifications/balloon_collection.cc (right):

http://codereview.chromium.org/338051/diff/34/44#newcode56
Line 56: int current_max_length = max_balloon_length * count();
On 2009/10/28 18:56:16, Ben Goodger wrote:
> I thought you were going to change these to "size"?

Sorry, I changed the method naming but not the variables here.  Done.

http://codereview.chromium.org/338051/diff/34/45
File chrome/browser/notifications/balloon_collection.h (right):

http://codereview.chromium.org/338051/diff/34/45#newcode121
Line 121: HORIZONTALLY_FROM_BOTTOM_LEFT,
On 2009/10/28 18:56:16, Ben Goodger wrote:
> Are we actually going to use these horizontal modes? I mentioned this to
> glen/cole and they saw no use for them.

Probably they are overkill if we don't plan to use that style... I can take them
out; it would probably not be hard to recreate them someday.

http://codereview.chromium.org/338051/diff/34/43
File chrome/browser/views/notifications/balloon_view_host_win.cc (right):

http://codereview.chromium.org/338051/diff/34/43#newcode77
Line 77: RenderWidgetHostViewWin* view = new RenderWidgetHostViewWin(rvh);
On 2009/10/28 18:56:16, Ben Goodger wrote:
> It hurts me that we have this whole file because this construction and the
HWND
> creation below is windows-specific. Can you improve this?

I would like to improve it but it's not obvious how... looking around for
guidance I see this same technique used by
browser/views/extensions/extension_view.cc (with an #ifdef though).

I can continue to look into it but do you think this is a blocker given that
non-windows notifications are a TODO already?

[Ben Goodger (Google), 2009-10-28 22:30:48]

LGTM.