Issue 338047: Actually copy the autofill data into the FormFieldValues vector. Fixes a reg...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338047: Actually copy the autofill data into the FormFieldValues vector. Fixes a reg... (Closed)

Created:
11 years, 1 month ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Actually copy the autofill data into the FormFieldValues vector. Fixes a regression caused by r29913. BUG=25874 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30229

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/common/render_messages.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM I think we need some more autofill tests given that the existing tests missed ...

11 years, 1 month ago (2009-10-27 18:21:16 UTC) #2

James Hawkins

11 years, 1 month ago (2009-10-27 18:24:48 UTC) #3

On 2009/10/27 18:21:16, darin wrote:
> LGTM
> 
> I think we need some more autofill tests given that the existing tests missed
> this regression.  I think that is fine to do as a follow-up CL since this
change
> is blocking the dev channel.

I definitely agree.  The tests will be added as part of my autofill work.

Expand Messages | Collapse Messages