Got the about panel to have its text lined up correctly.

Got the about panel to have its text lined up correctly.
Also added underline capability to linux fonts.

[sky, 2009-10-26 23:55:27]

http://codereview.chromium.org/338029/diff/2001/3001
File app/gfx/canvas_linux.cc (right):

http://codereview.chromium.org/338029/diff/2001/3001#newcode197
Line 197: cairo_rectangle(cr, x, y, width, height);
How come you're doing this change? Don't we want to clip to the supplied size?

http://codereview.chromium.org/338029/diff/2001/3001#newcode203
Line 203: gfx::Font mut_font = const_cast<gfx::Font&>(font);
Do you really need non-const here? If so, this should be a reference.

http://codereview.chromium.org/338029/diff/2001/3001#newcode204
Line 204: double underline_y = (double)y + height +
mut_font.underline_position();
static_cast<double>

http://codereview.chromium.org/338029/diff/2001/3002
File app/gfx/font.h (right):

http://codereview.chromium.org/338029/diff/2001/3002#newcode140
Line 140: double underline_position() const;
Descriptions?

http://codereview.chromium.org/338029/diff/2001/3003
File app/gfx/font_skia.cc (right):

http://codereview.chromium.org/338029/diff/2001/3003#newcode176
Line 176: void Font::InitPangoMetrics() {
The problem with this approach is that if you end up creating a font like:

gfx::Font font = supplied_font;

Which is done in a bunch of a places, you have to calculate the metrics again.
You should move the metrics into a ref counted class so that it's only
calculated once for a font. I did something similar to this in r26141.

[DaveMoore, 2009-10-27 22:05:21]

http://codereview.chromium.org/338029/diff/2001/3001
File app/gfx/canvas_linux.cc (right):

http://codereview.chromium.org/338029/diff/2001/3001#newcode197
Line 197: cairo_rectangle(cr, x, y, width, height);
On 2009/10/26 23:55:27, sky wrote:
> How come you're doing this change? Don't we want to clip to the supplied size?

I'll change this to move the clip above the y position adjustment so we can clip
to the original coordinates.

http://codereview.chromium.org/338029/diff/2001/3001#newcode203
Line 203: gfx::Font mut_font = const_cast<gfx::Font&>(font);
On 2009/10/26 23:55:27, sky wrote:
> Do you really need non-const here? If so, this should be a reference.

Done.

http://codereview.chromium.org/338029/diff/2001/3001#newcode204
Line 204: double underline_y = (double)y + height +
mut_font.underline_position();
On 2009/10/26 23:55:27, sky wrote:
> static_cast<double>

Done.

http://codereview.chromium.org/338029/diff/2001/3002
File app/gfx/font.h (right):

http://codereview.chromium.org/338029/diff/2001/3002#newcode140
Line 140: double underline_position() const;
On 2009/10/26 23:55:27, sky wrote:
> Descriptions?

Done.

http://codereview.chromium.org/338029/diff/2001/3003
File app/gfx/font_skia.cc (right):

http://codereview.chromium.org/338029/diff/2001/3003#newcode176
Line 176: void Font::InitPangoMetrics() {
I added a font metrics cache.

On 2009/10/26 23:55:27, sky wrote:
> The problem with this approach is that if you end up creating a font like:
> 
> gfx::Font font = supplied_font;
> 
> Which is done in a bunch of a places, you have to calculate the metrics again.
> You should move the metrics into a ref counted class so that it's only
> calculated once for a font. I did something similar to this in r26141.

[sky, 2009-10-27 22:48:58]

LGTM assuming pango_context_get_metrics doesn't use the PangoFontDescription
supplied to it after the call returns.