Issue 338028: ResourceBundle::GetRawDataResource should fall back to localized resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338028: ResourceBundle::GetRawDataResource should fall back to localized resources (Closed)

Created:
11 years, 1 month ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
tony, TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

ResourceBundle::GetRawDataResource should fall back to localized resources on Mac and Linux as it does on Windows. BUG=25869 TEST=about:terms should work. In a branded build, terms should show up. In an unbranded build, the about:terms page is supposed to be blank, but there should be some skeletal HTML visible in "View Source". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30130

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	app/resource_bundle_linux.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
	M	app/resource_bundle_mac.mm	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

One sorta-problem is that base::DataPack::Get does a LOG(ERROR) when a resource isn't found. That means ...

11 years, 1 month ago (2009-10-26 23:26:24 UTC) #1

TVL

11 years, 1 month ago (2009-10-27 01:32:00 UTC) #3

lgtm.

should we file a helpwanted & fixit bug to get some of this shared between
mac/linux since there is a bunch of common code?

Expand Messages | Collapse Messages