Issue 338027: Modify DataPacks so they can return RefCountedStaticMemory objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338027: Modify DataPacks so they can return RefCountedStaticMemory objects. (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Modify DataPacks so they can return RefCountedStaticMemory objects. (This is in preparation for a very large reworking of BrowserThemeProvider). BUG=http://crbug.com/21121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30241

Patch Set 1 #

Patch Set 2 : Mac fixes #

Total comments: 2

Patch Set 3 : Rewrite GetStaticMemory #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
M	app/resource_bundle_linux.cc	View		2 chunks	+3 lines, -8 lines	0 comments	Download
M	app/resource_bundle_mac.mm	View	1	2 chunks	+3 lines, -8 lines	0 comments	Download
M	base/data_pack.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	base/data_pack.cc	View	1 2	2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/338027/diff/10/1003 File base/data_pack.cc (right): http://codereview.chromium.org/338027/diff/10/1003#newcode123 Line 123: } Can this be implemented in terms of ...

11 years, 1 month ago (2009-10-26 23:33:58 UTC) #2

Elliot Glaysher

http://codereview.chromium.org/338027/diff/10/1003 File base/data_pack.cc (right): http://codereview.chromium.org/338027/diff/10/1003#newcode123 Line 123: } On 2009/10/26 23:33:58, Evan Martin wrote: > ...

11 years, 1 month ago (2009-10-26 23:51:37 UTC) #3

Evan Martin

11 years, 1 month ago (2009-10-26 23:57:42 UTC) #4

LGTM

http://codereview.chromium.org/338027/diff/5001/5004
File base/data_pack.cc (right):

http://codereview.chromium.org/338027/diff/5001/5004#newcode120
Line 120: }
curlies not necessary here

Expand Messages | Collapse Messages