Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 338023: Fix a bad comparator. This caused lookups in std::map to be wrong.... (Closed)

Created:
11 years, 1 month ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a bad comparator. This caused lookups in std::map to be wrong. BUG=25823 TEST=HostCacheTest.KeyComparator Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30084

Patch Set 1 #

Patch Set 2 : Change test name #

Patch Set 3 : Remove %s from format string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M net/base/host_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/host_cache_unittest.cc View 1 2 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
11 years, 1 month ago (2009-10-26 19:16:21 UTC) #1
kuchhal
11 years, 1 month ago (2009-10-26 19:19:03 UTC) #2
lgtm.

Powered by Google App Engine
This is Rietveld 408576698