Issue 338013: Polish to the gmail checker sample.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338013: Polish to the gmail checker sample. (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Polish to the gmail checker sample. * New, crisper icons that are exactly 19x19 * Add a loading animation at the beginning before Gmail responds. * Fix a bug where we sometimes don't update the UI after a logout/login cycle. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30067

Patch Set 1 #

Patch Set 2 : new, crisper icons #

Patch Set 3 : Remove dead code #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -24 lines)			Patch
M	chrome/test/data/extensions/samples/gmail_browser_action/background.html	View	1 2	5 chunks	+64 lines, -22 lines	0 comments	Download
M	chrome/test/data/extensions/samples/gmail_browser_action/gmail_logged_in.png	View	1	Binary file		0 comments	Download
M	chrome/test/data/extensions/samples/gmail_browser_action/gmail_not_logged_in.png	View	1	Binary file		0 comments	Download
M	chrome/test/data/extensions/samples/gmail_browser_action/manifest.json	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Screen cap here: http://dl.getdropbox.com/u/124107/crisper.png

11 years, 1 month ago (2009-10-26 03:07:04 UTC) #1

lgtm. nice!

Expand Messages | Collapse Messages