Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4737)

Unified Diff: chrome/browser/cocoa/about_window_controller.h

Issue 338012: About box auto-update improvements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/cocoa/about_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/about_window_controller.h
===================================================================
--- chrome/browser/cocoa/about_window_controller.h (revision 30049)
+++ chrome/browser/cocoa/about_window_controller.h (working copy)
@@ -5,22 +5,17 @@
#ifndef CHROME_BROWSER_COCOA_ABOUT_WINDOW_CONTROLLER_H_
#define CHROME_BROWSER_COCOA_ABOUT_WINDOW_CONTROLLER_H_
-#import <Cocoa/Cocoa.h>
-#include "base/scoped_nsobject.h"
-#import "chrome/app/keystone_glue.h"
+#import <AppKit/AppKit.h>
@class BackgroundTileView;
class Profile;
-// Returns an NSAttributedString that contains the locale specific legal text.
-NSAttributedString* BuildAboutWindowLegalTextBlock();
+// kUserClosedAboutNotification is the name of the notification posted when
+// the About window is closed.
+extern const NSString* const kUserClosedAboutNotification;
-// A window controller that handles the branded (Chrome.app) about
-// window. The branded about window has a few features beyond the
-// standard Cocoa about panel. For example, opening the about window
-// will check to see if this version is current and tell the user.
-// There is also an "update me now" button with a progress spinner.
-@interface AboutWindowController : NSWindowController<KeystoneGlueCallbacks> {
+// A window controller that handles the About box.
+@interface AboutWindowController : NSWindowController {
@private
IBOutlet NSTextField* version_;
IBOutlet BackgroundTileView* backgroundView_;
@@ -35,9 +30,6 @@
BOOL updateTriggered_; // Has an update ever been triggered?
Profile* profile_; // Weak, probably the default profile.
-
- // The version we got told about by Keystone
- scoped_nsobject<NSString> newVersionAvailable_;
}
// Initialize the controller with the given profile, but does not show it.
@@ -47,17 +39,17 @@
// Trigger an update right now, as initiated by a button.
- (IBAction)updateNow:(id)sender;
-@end
+@end // @interface AboutWindowController
+@interface AboutWindowController(JustForTesting)
-@interface AboutWindowController (JustForTesting)
- (NSTextView*)legalText;
- (NSButton*)updateButton;
- (NSTextField*)updateText;
-@end
+// Returns an NSAttributedString that contains locale-specific legal text.
++ (NSAttributedString*)legalTextBlock;
-// NSNotification sent when the about window is closed.
-extern NSString* const kUserClosedAboutNotification;
+@end // @interface AboutWindowController(JustForTesting)
#endif // CHROME_BROWSER_COCOA_ABOUT_WINDOW_CONTROLLER_H_
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/cocoa/about_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698