Issue 338010: Hopefully the last of the fixes to get Chrome Frame tests going again. Added ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338010: Hopefully the last of the fixes to get Chrome Frame tests going again. Added ... (Closed)

Created:
11 years, 2 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Hopefully the last of the fixes to get Chrome Frame tests going again. 1. Added a check in the OnDestroy handler for the ChromeFrame ActiveX as to whether the worker thread is valid before posting a task to it. 2. Added a helper function in ChromeFrameAutomationClient to support asynchronous host network stack requests deletion. If this does not work I will revert the previous CL's. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30010

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
M	chrome_frame/chrome_frame_activex_base.h	View	1 2 3 4	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome_frame/chrome_frame_automation.h	View	4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame_automation.cc	View	3 4	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages