Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 338005: Find-in-page should not ding while deleting characters. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents.cc (revision 30046)
+++ chrome/browser/tab_contents/tab_contents.cc (working copy)
@@ -1084,6 +1084,9 @@
find_text = *last_search_prepopulate_text_;
}
+ // Keep track of the previous search.
+ previous_find_text_ = find_text_;
+
// This is a FindNext operation if we are searching for the same text again,
// or if the passed in search text is empty (FindNext keyboard shortcut). The
// exception to this is if the Find was aborted (then we don't want FindNext
@@ -1117,6 +1120,7 @@
// by the user, but the UI has not been dismissed.
if (!clear_selection)
find_ui_active_ = false;
+ find_text_ = string16();
Peter Kasting 2009/10/26 21:04:33 Nit: Use "find_text_.clear();"
find_op_aborted_ = true;
last_search_result_ = FindNotificationDetails();
render_view_host()->StopFinding(clear_selection);
« chrome/browser/find_bar_controller.cc ('K') | « chrome/browser/tab_contents/tab_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698