Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 3380029: Clean up site_wlan_connect.py a bit (Closed)

Created:
10 years, 2 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Clean up site_wlan_connect.py a bit Minor fixes include: * Collapse usages of "org.chromium.flimflam" into a single reference * Display the content of a few DBus exceptions * Remove an ErrExit that was never reached * Add a utility function to dump all services during DumpLogs() BUG=none TEST=run_wifi_tests -- both success output and quirk output verified Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e6645d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M server/site_wlan_connect.py View 6 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 2 months ago (2010-09-27 16:40:07 UTC) #1
Sam Leffler
10 years, 2 months ago (2010-09-27 16:52:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698