Issue 3380022: Fix build break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3380022: Fix build break. (Closed)

Created:
10 years, 3 months ago by thieule

Modified:
9 years, 4 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crash-reporter.git

Visibility:
Public.

Description

Fix build break. BUG=6446 TEST=unit test, logging_UserCrash Change-Id: Iac9f5484d9218ef91ae606ef410409df5ec16382 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=11d6c5b

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	crash_reporter.cc	View		2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 3 months ago (2010-09-21 23:56:15 UTC) #2

LGTM with nit.

No need to upload again once you fix it

http://codereview.chromium.org/3380022/diff/1/2
File crash_reporter.cc (right):

http://codereview.chromium.org/3380022/diff/1/2#newcode147
crash_reporter.cc:147: CommandLine::Init(argc,argv);
nit: space after the comma

Expand Messages | Collapse Messages