Linux: make compile-time dependency on gnome-keyring optional.

Linux: make compile-time dependency on gnome-keyring optional.

This is upstreaming a Gentoo Linux patch.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59587

[Evan Martin, 2010-09-14 22:58:15]

http://codereview.chromium.org/3380004/diff/1/2
File build/linux/system.gyp (right):

http://codereview.chromium.org/3380004/diff/1/2#newcode8
build/linux/system.gyp:8: # optional. This is useful for Linux distributions.
This comment describes why this option is here, but doesn't describe what the
option actually *means*.  Maybe mention something like: if 0, remove all
gnome-keyring related code.

http://codereview.chromium.org/3380004/diff/1/2#newcode268
build/linux/system.gyp:268: ['chromeos==0 and use_gnome_keyring==1', {
Is this condition actually needed?  Isn't it enough to just not depend on the
gnome-keyring target from chrome_browser.gypi?

http://codereview.chromium.org/3380004/diff/1/4
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/3380004/diff/1/4#newcode3185
chrome/chrome_browser.gypi:3185: ['chromeos==1 or use_gnome_keyring==0', {
I wonder if we could make the default value of this flag depend on the chromeos
flag, rather than testing both of these.

[Paweł Hajdan Jr., 2010-09-15 21:18:41]

Please take another look.

[Evan Martin, 2010-09-15 21:28:27]

http://codereview.chromium.org/3380004/diff/6001/7002
File build/linux/system.gyp (right):

http://codereview.chromium.org/3380004/diff/6001/7002#newcode262
build/linux/system.gyp:262: ['use_gnome_keyring==1', {
Is this still necessary?  Won't this target be unused when use_gnome_keyring is
0, so this won't be evaluated anyway?

...I'm not sure, so I'm asking you.  :)

[Paweł Hajdan Jr., 2010-09-15 21:56:03]

http://codereview.chromium.org/3380004/diff/6001/7002
File build/linux/system.gyp (right):

http://codereview.chromium.org/3380004/diff/6001/7002#newcode262
build/linux/system.gyp:262: ['use_gnome_keyring==1', {
On 2010/09/15 21:28:27, Evan Martin wrote:
> Is this still necessary?  Won't this target be unused when use_gnome_keyring
is
> 0, so this won't be evaluated anyway?
> 
> ...I'm not sure, so I'm asking you.  :)

I was getting errors without this if gnome-keyring was not present on the system
(gyp would still evaluate and execute the command).

[Evan Martin, 2010-09-15 21:58:44]

LGTM

[Mark Mentovai, 2010-09-15 23:18:11]

LGTM