Issue 3374005: Do not create a new process group so session manager could kill ibus daemons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3374005: Do not create a new process group so session manager could kill ibus daemons. (Closed)

Created:
10 years, 3 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Peng

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush, Zachary Kuznia, satorux1, Chris Masone

Base URL:
ssh://git@chromiumos-git//chromiumos-overlay.git

Visibility:
Public.

Description

Do not create a new process group so session manager could kill ibus daemons. BUG=chromium-os:6515 TEST=ran 'ps xj' and verified that the first Chrome browser process and all ibus processes have the same PGID.

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	A	app-i18n/ibus/files/ibus-1.3.7-no-create-new-process-group.patch	View		1 chunk	+13 lines, -0 lines	0 comments	Download
	A +	app-i18n/ibus/ibus-1.3.7-r17.ebuild	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Ah, probably I should try to commit the change to http://github.com/ibus/ibus/commits/chromeos/ first, and then update ...

10 years, 3 months ago (2010-09-13 04:32:13 UTC) #2

Yusuke Sato

http://codereview.appspot.com/2168046/diff/1/bus/main.c On 2010/09/13 04:32:13, Yusuke Sato wrote: > Ah, probably I should try to commit ...

10 years, 3 months ago (2010-09-13 04:59:25 UTC) #3

Yusuke Sato

10 years, 3 months ago (2010-09-13 08:42:22 UTC) #4

I'll revert the change.
http://code.google.com/p/chromium-os/issues/detail?id=6515#c13

On 2010/09/13 04:59:25, Yusuke Sato wrote:
> http://codereview.appspot.com/2168046/diff/1/bus/main.c
> 
> On 2010/09/13 04:32:13, Yusuke Sato wrote:
> > Ah, probably I should try to commit the change to
> > http://github.com/ibus/ibus/commits/chromeos/ first, and then update
> > app-i18n/ibus/files/ibus-chromiumos.patch?
> > 
> > Please stop the review for now.

Expand Messages | Collapse Messages