Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 3373003: Issue 6577: remove confirmation to delete output directory (Closed)

Created:
10 years, 3 months ago by Tan Gao
Modified:
9 years, 7 months ago
Reviewers:
davidjames, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Issue 6577: remove confirmation to delete output directory Change-Id: Ib19986121a8988c6cae23527148a7b5d4a58663e BUG=chromium-os:6577 TEST=(inside chroot) run 4 test cases from src/scripts/, using Ctrl+C to force abort (hence triggering "delete_prompt") a.) (stdin tty) "./build_image --board=x86-generic < /dev/null", expected = no prompt and delete output dir; actual == expected b.) (stdout tty) "./build_image --board=x86-generic > foo.txt", expected = no prompt and delete output dir; actual == expected c.) (normal user case) "./build_image --board=x86-generic", expected = prompt to delete output dir, if y, output dir is removed; actual == expected d.) (normal user case) "./build_image --board=x86-generic", expected = prompt to delete output dir, if N, output dir is NOT removed; actual == expected

Patch Set 1 #

Patch Set 2 : detect non-interactive mode and delete output dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M build_image View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tan Gao
10 years, 3 months ago (2010-09-09 17:54:33 UTC) #1
sosa
I don't like changing something that is useful for manual people for the purposes of ...
10 years, 3 months ago (2010-09-09 17:57:22 UTC) #2
Tan Gao
understood :-) CL updated. PTAL thx!
10 years, 3 months ago (2010-09-09 18:35:24 UTC) #3
sosa
10 years, 3 months ago (2010-09-09 18:40:19 UTC) #4
LGTM, thanks to both of you for compromising with me :D

Powered by Google App Engine
This is Rietveld 408576698