NTP Apps bug fixes.

chrome/browser/resources/new_new_tab.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // To avoid creating tons of unnecessary nodes. We assume we cannot fit more
 // than this many items in the miniview.
 var MAX_MINIVIEW_ITEMS = 15;
 
 // Extra spacing at the top of the layout.
 var LAYOUT_SPACING_TOP = 25;
@@ skipping 252 matching lines @@
   var gradientHeightPx = Math.min(10, Math.floor(visibleHeightPx / 2));
   var gradientDestination = 'rgba(0,0,0,' + (gradientHeightPx / 10) + ')';
 
   var bottomSpacing = 15;
   var first = parseFloat(maxiview.style.top) / window.innerHeight;
   var second = first + gradientHeightPx / window.innerHeight;
   var fourth = first + (visibleHeightPx - bottomSpacing) / window.innerHeight;
   var third = fourth - gradientHeightPx / window.innerHeight;
 
   var gradientArguments = [
-    "linear",
-    "0 0",
-    "0 100%",
-    "from(transparent)",
-    getColorStopString(first, "transparent"),
+    'linear',
+    '0 0',
+    '0 100%',
+    'from(transparent)',
+    getColorStopString(first, 'transparent'),
     getColorStopString(second, gradientDestination),
     getColorStopString(third, gradientDestination),
-    getColorStopString(fourth, "transparent"),
-    "to(transparent)"
+    getColorStopString(fourth, 'transparent'),
+    'to(transparent)'
   ];
 
   var gradient = '-webkit-gradient(' + gradientArguments.join(', ') + ')';
   maxiview.style.WebkitMaskImage = gradient;
 }
 
 function getColorStopString(height, color) {
-  return "color-stop(" + height + ", " + color + ")";
+  return 'color-stop(' + height + ', ' + color + ')';
 }
 
 window.addEventListener('resize', handleWindowResize);
 
 var sectionToElementMap;
 function getSectionElement(section) {
   if (!sectionToElementMap) {
     sectionToElementMap = {};
     for (var key in Section) {
       sectionToElementMap[Section[key]] =
@@ skipping 50 matching lines @@
         maxiview.classList.add('hiding');
 
       var miniview = el.getElementsByClassName('miniview')[0];
       if (miniview)
         updateMiniviewClipping(miniview);
     }
   }
 }
 
 window.addEventListener('webkitTransitionEnd', function(e) {
-  if (e.target.classList.contains('hiding'))
+  if (e.target.classList.contains('hiding')) {
     e.target.classList.add('hidden');
+    e.target.classList.remove('hiding');
+  }
 
-  document.documentElement.setAttribute("enable-section-animations", "false");
+  document.documentElement.setAttribute('enable-section-animations', 'false');
 });
 
 /**
  * Callback when the shown sections changes in another NTP.
  * @param {number} newShownSections Bitmask of the shown sections.
  */
 function setShownSections(newShownSections) {
   for (var key in Section) {
     if (newShownSections & Section[key])
       showSection(Section[key]);
@@ skipping 276 matching lines @@
 $('main').addEventListener('click', function(e) {
   var p = e.target;
   while (p && p.tagName != 'H2') {
     // In case the user clicks on a button we do not want to expand/collapse a
     // section.
     if (p.tagName == 'BUTTON')
       return;
     p = p.parentNode;
   }
 
-  if (!p) {
+  if (!p)
     return;
-  }
 
   p = p.parentNode;
-  if (!getSectionMaxiview(p)) {
+  if (!getSectionMaxiview(p))
     return;
+
+  toggleSectionVisibilityAndAnimate(p.getAttribute('section'));
+});
+
+function toggleSectionVisibilityAndAnimate(section) {
+  if (!section)
+    return;
+
+  // We set it back in webkitTransitionEnd.
+  document.documentElement.setAttribute('enable-section-animations', 'true');
+  if (shownSections & Section[section]) {
+    hideSection(Section[section]);
+  } else {
+    for (var p in Section) {
+      if (p == section)
+        showSection(Section[p]);
+      else
+        hideSection(Section[p]);
+    }
   }
-
-  var section = p.getAttribute('section');
-  if (section) {
-    // We set it back in webkitTransitionEnd.
-    document.documentElement.setAttribute("enable-section-animations", "true");
-    if (shownSections & Section[section]) {
-      hideSection(Section[section]);
-    } else {
-      for (var p in Section) {
-        if (p == section)
-          showSection(Section[p]);
-        else
-          hideSection(Section[p]);
-      }
-    }
-    layoutSections();
-    saveShownSections();
-  }
-});
+  layoutSections();
+  saveShownSections();
+}
 
 function handleIfEnterKey(f) {
   return function(e) {
-    if (e.keyIdentifier == 'Enter') {
+    if (e.keyIdentifier == 'Enter')
       f(e);
-    }
   };
 }
 
 function maybeReopenTab(e) {
   var el = findAncestor(e.target, function(el) {
     return el.sessionId !== undefined;
   });
   if (el) {
     chrome.send('reopenTab', [String(el.sessionId)]);
     e.preventDefault();
@@ skipping 232 matching lines @@
   window.setTimeout(function() {
     mostVisited.ensureSmallGridCorrect();
     document.body.classList.remove('loading');
   }, 1);
 
   // Only show the first run notification if first run.
   if (firstRun) {
     showFirstRunNotification();
   }
 }