NTP Apps bug fixes.

NTP Apps bug fixes.

o Only do the bounce animation once when installing an app. Collapsing and expanding the apps section would cause the new app icon to bounce again.
o Expand the Apps section if it is collapsed and a new app isn't installed.

BUG=53974, 54421
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59014

[Aaron Boodman, 2010-09-09 20:40:30]

lgtm - thanks for the cleanup

http://codereview.chromium.org/3371010/diff/2001/3002
File chrome/browser/resources/ntp/apps.js (left):

http://codereview.chromium.org/3371010/diff/2001/3002#oldcode6
chrome/browser/resources/ntp/apps.js:6: logEvent('recieved apps');
heh. http://www.youtube.com/watch?v=eSBhC3k2XOo

[Aaron Boodman, 2010-09-09 20:43:01]

You should expand the code review description. It is nice to have a summary of
the change, even if it is also described in the bug(s). That way people can see
what is going on when they review the history.

[Aaron Boodman, 2010-09-09 20:44:44]

One more thing -- this should be merged to 517. You'll have to get one of the
tpm's approval, such as laforge.

[Bons, 2010-09-09 21:09:02]

On 2010/09/09 20:43:01, Aaron Boodman wrote:
> You should expand the code review description. It is nice to have a summary of
> the change, even if it is also described in the bug(s). That way people can
see
> what is going on when they review the history.

Done. I was simply being lazy.

Will merge as well.

[arv (Not doing code reviews), 2010-09-09 21:26:22]

LGTM

http://codereview.chromium.org/3371010/diff/2001/3002
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/3371010/diff/2001/3002#newcode160
chrome/browser/resources/ntp/apps.js:160: }, false);
the third arg of addEventListener defaults false already.

Thank God for Webkit getting DOM arguments correct.

[Bons, 2010-09-09 22:51:50]

http://codereview.chromium.org/3371010/diff/2001/3002
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/3371010/diff/2001/3002#newcode160
chrome/browser/resources/ntp/apps.js:160: }, false);
On 2010/09/09 21:26:23, arv wrote:
> the third arg of addEventListener defaults false already.
> 
> Thank God for Webkit getting DOM arguments correct.

Seriously.