Issue 337042: Revert 30168 - Commit patch set from http://codereview.chromium.org/149796...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337042: Revert 30168 - Commit patch set from http://codereview.chromium.org/149796... (Closed)

Created:
11 years, 1 month ago by Roland

Modified:
9 years, 7 months ago

Reviewers:
Roland Steiner

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, Paul Godavari, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Revert 30168 - Commit patch set from http://codereview.chromium.org/149796 (see discussion and history there) BUG=10876 TEST=FilePathTest.MatchesExtension.CompareIgnoreCase TBR=rolandsteiner@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30170

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -813 lines)			Patch
M	base/file_path.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	base/file_path.cc	View	4 chunks	+4 lines, -606 lines	0 comments	Download
M	base/file_path_unittest.cc	View	4 chunks	+14 lines, -111 lines	0 comments	Download
M	chrome/browser/download/download_manager.h	View	2 chunks	+4 lines, -14 lines	0 comments	Download
M	chrome/browser/download/download_manager.cc	View	10 chunks	+26 lines, -39 lines	0 comments	Download
M	chrome/browser/download/download_shelf.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/net/url_fixer_upper_unittest.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/shell_integration_win.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)