Fix bug where many extensions don't install due to sandbox.

Fix bug where many extensions don't install due to sandbox.

FWIW, I tracked down why our tests didn't find this. We do 
have coverage for the code path that was getting executed, 
but the sandbox is disabled in our browser tests, so it did 
not expose this issue.

BUG=25865
TEST=Install any extension that has a content script or icons (test/data/extensions/good.crx is one example). Go to chrome://extensions/. You should see the extension successfully installed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30282

[Aaron Boodman, 2009-10-27 05:53:05]

Cira, Sorry for grabbing this bug out from under you when you'd already started
on it. Up until an hour ago we were planning on cutting a release tonight, and
it would have been bad to have this bug present.

[Nebojša Ćirić, 2009-10-27 17:13:01]

LGTM

I wanted to do:

string GetCurrentLocaleOrDefault(const string& default) {
 static string locale;
 if (!default.empty()) {
   locale = default;
   return locale;
 }
 
 if (locale.empty())
   locale = l10n_util::GetApplicationLocale(L"");

 return locale;
}

[Matt Perry, 2009-10-27 18:19:57]

lgtm

[Aaron Boodman, 2009-10-27 21:57:19]

New snapshot. Moved extension_l10n_util from browser to common.

[Matt Perry, 2009-10-27 21:58:29]

OK

[Nebojša Ćirić, 2009-10-27 22:04:35]

LGTM

http://codereview.chromium.org/337041/diff/4001/5003
File chrome/chrome.gyp (right):

http://codereview.chromium.org/337041/diff/4001/5003#newcode542
Line 542: 'common/extensions/extension_action.h',
action2->action changes are result of a merge?

http://codereview.chromium.org/337041/diff/4001/5004
File chrome/common/extensions/extension_l10n_util.cc (right):

http://codereview.chromium.org/337041/diff/4001/5004#newcode201
Line 201: *current_locale = l10n_util::GetApplicationLocale(L"");
No big deal, but you could use

SetProcessLocale(l10n_util::GetApplicationLocale(L""));

instead.